Changed symfony/web-server-bundle to dev package #8834
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symfony/web-server-bundle package should be installed as dev requirement. This bundle is not neeable for production.
javiereguiluz
approved these changes
Dec 6, 2017
There was a problem hiding this comment.
@xyNNN you are completely right! Thanks for fixing it and congrats on your first docs contribution.
Note to mergers: merge on 4.0 branch instead.
|
I'm happy to contribute 👍 |
xabbuh
approved these changes
Dec 7, 2017
|
Thank you @xyNNN. |
xabbuh
added a commit
that referenced
this pull request
Dec 8, 2017
This PR was submitted for the master branch but it was merged into the 4.0 branch instead (closes #8834). Discussion ---------- Changed symfony/web-server-bundle to dev package The symfony/web-server-bundle package should be installed as dev requirement. This bundle is not needable for production. Commits ------- 72d2edb Changed symfony/web-server-bundle to dev package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symfony/web-server-bundle package should be installed as dev requirement. This bundle is not needable for production.